Conversion to and from PitchClass tuple form would be simpler if the Accidental type didn't exist, because Offsets can't be converted to Accidentals, only to Maybe Accidentals or similar.
Since Accidental exists mainly to help a programmer think in terms of music notation as limited to triple accidentals, we could replace this type with convenience functions natural, sharp, flat, doubleSharp, doubleFlat, tripleSharp, and tripleFlat which would return Offsets of the correct values. This, I think, would achieve the same effect, and would allow PitchClass to tuple conversion to be a reversible process.
Conversion to and from
PitchClasstuple form would be simpler if theAccidentaltype didn't exist, becauseOffsets can't be converted toAccidentals, only toMaybe Accidentals or similar.Since
Accidentalexists mainly to help a programmer think in terms of music notation as limited to triple accidentals, we could replace this type with convenience functionsnatural,sharp,flat,doubleSharp,doubleFlat,tripleSharp, andtripleFlatwhich would returnOffsets of the correct values. This, I think, would achieve the same effect, and would allowPitchClassto tuple conversion to be a reversible process.