search

elm-street-technology / elevate-ui

🎨 💻 📱An opinionated toolkit of React components and patterns
https://elevate-ui.com/
MIT License
10 stars 4 forks source link

Theme Permanently Overwritten After First Overwrite #153

Closed jwdotjs closed 5 years ago

jwdotjs commented 5 years ago

https://github.com/elm-street-technology/elevate-ui/blob/da04809feec51530e21548c95d404c083a50b7a8/src/ThemeProvider/index.js#L194

When a theme has overwrite, it's permanent thereafter. I think we can change this line to const mergedTheme = theme ? merge({}, defaultTheme, theme) : defaultTheme; to prevent permanent overwrite.

chrisheninger commented 5 years ago

Published as 0.25.0