search

elm-tooling / elm-language-server-haskell

Elm language server written in haskell (archived). Use https://github.com/elm-tooling/elm-language-server instead.
BSD 3-Clause "New" or "Revised" License
52 stars 5 forks source link

Add cicrcleci config #1

Closed razzeee closed 5 years ago

razzeee commented 6 years ago

So this builds fine, but you need to setup a circleci account for your repo.

It's mostly a copy job from https://github.com/haskell/haskell-ide-engine/blob/master/.circleci/config.yml

matheus23 commented 5 years ago

The circleci config contains a lot of things very specific to the haskell-ide-engine project. There are still traces of their configuration of building for several different ghc versions (which we don't need to do). They use a custom docker image, of which I have no idea how it works.

I would rather build up a configuration that is much less complex, since its vital to have someone who understands the CI configuration in case anything goes wrong.

I have quite some experience with gitlab's ci for haskell, so it shouldn't be much of an issue creating a CI file.

Since maybe people want to contribute to this project (like you, even if it is just a change in dependencies), it would be beneficial to have a CI so I can confidently merge pull requests. This seems like it should be a higher priority for me :) I'll work on it right now.

I'll close this now. Can you reopen another PR with only the unix dependency change? It is important, but not related.

Thanks!

razzeee commented 5 years ago

I will send that change separate then. My rational was that I wanted to see if it really does build without Unix on Unix ;)

On Sat, 3 Nov 2018, 13:55 Philipp Krüger, notifications@github.com wrote:

The circleci config contains a lot of things very specific to the haskell-ide-engine project. There are still traces of their configuration of building for several different ghc versions (which we don't need to do). They use a custom docker image, of which I have no idea how it works.

I would rather build up a configuration that is much less complex, since its vital to have someone who understands the CI configuration in case anything goes wrong.

I have quite some experience with gitlab's ci for haskell, so it shouldn't be much of an issue creating a CI file.

Since maybe people want to contribute to this project (like you, even if it is just a change in dependencies), it would be beneficial to have a CI so I can confidently merge pull requests. This seems like it should be a higher priority for me :) I'll work on it right now.

I'll close this now. Can you reopen another PR with only the unix dependency change? It is important, but not related.

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matheus23/elm-language-server/pull/1#issuecomment-435585789, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqyZJqiWAeSMNduwQg-MkBwrw976WdWks5urZI8gaJpZM4YMO1m .