search

elm-tooling / tree-sitter-elm

Tree sitter implementation for elm
https://elm-tooling.github.io/tree-sitter-elm/
MIT License
75 stars 14 forks source link

Relax tree-sitter version bounds to include 0.20.x #107

Closed jwoudenberg closed 2 years ago

jwoudenberg commented 2 years ago

Hi there! I've been happily using the rust crate provided by this repo for the last month or so. I've noticed that the version of tree-sitter pinned here (0.19.5) is a bit behind the latest release (0.20.1). This PR relaxes the version bounds to include the old 0.19.5 and 0.20.x both.

Based on my own testing with version 0.20.1 this doesn't result in any problems.

razzeee commented 2 years ago

Any reason to not just update completely? I'm not sure if the cargo file get's generated at build time, has been some time since I last did it.

jwoudenberg commented 2 years ago

Sorry, I don't completely understand your question. Can you expand on what you mean by 'update completely'? Do you mean pinning the tree-sitter dependency to 0.2.1 exactly?

razzeee commented 2 years ago

I've done the update here https://github.com/elm-tooling/tree-sitter-elm/pull/108 but turns out, there is a regression in an error case.

jwoudenberg commented 2 years ago

Oh, I see now. Will close this PR either way, since yours is much more comprehensive!

razzeee commented 2 years ago

Thank you for pushing me to get this updated ;)

jwoudenberg commented 2 years ago

I didn't do much! Thank you for doing the work!