search

elm-tooling / tree-sitter-elm

Tree sitter implementation for elm
https://elm-tooling.github.io/tree-sitter-elm/
MIT License
74 stars 12 forks source link

fix: mark helper functions static, remove comments #138

Closed amaanq closed 1 year ago

amaanq commented 1 year ago

Max noticed this conflict when compiling with another scanner with a scan function, marking them static fixes that

Thanks!

razzeee commented 1 year ago

Not sure which conflict, but I guess I'll trust you :)

amaanq commented 1 year ago

If you compile two parsers in a project where both have a scanner with a function scan then they will get linked to one of the parser's scan (for the original that is ok, but the other one will use another parser's scan which is bad)

I'm going around fixing this everywhere :sweat_smile: Max gave me a shout about Elm specifically as he had that exact problem

razzeee commented 1 year ago

I guess you don't need a release, right?

amaanq commented 1 year ago

Not entirely, though anyone using crates.io @ the latest version (not git) will encouter this, you could do a patch bump maybe to 5.6.6 if you'd like

razzeee commented 1 year ago

Preparing in https://github.com/elm-tooling/tree-sitter-elm/pull/139