elm / compiler

Compiler for Elm, a functional language for reliable webapps.
https://elm-lang.org/
BSD 3-Clause "New" or "Revised" License
7.48k stars 658 forks source link

Re-releasing packages with different github usernames (and not v1.0.0) breaks package download endpoints #2293

Open jxlxx opened 1 year ago

jxlxx commented 1 year ago

Quick Summary: Skinney/murmur3 v2.0.8 has been re-released as robinheghan/murmur3 v1.0.0, and now anything using the Skinney version breaks (because GitHub tracks username changes, but their versions are different).

Full Explanation:

SSCCE

elm install Skinney/murmur3

Additional Details

Some context for the re-release: https://github.com/robinheghan/murmur3/commit/ec218ceddae5185d01e7eda33f1cb715da045671

Would just releasing robinheghan/murmur3@1.0.0 at v2.0.8? I think so. But I also think this might be a recurring issue (anytime someone changes their GitHub name for a package that isn't version 1.0.0).

CLI output:

$ elm install Skinney/murmur3
Here is my plan:

  Add:
    Skinney/murmur3    2.0.8

Would you like me to update your elm.json accordingly? [Y/n]: Y
-- PROBLEM DOWNLOADING PACKAGE -------------------------------------------------

I was trying to download the source code for Skinney/murmur3 2.0.8, so I tried
to fetch:

    https://github.com/Skinney/murmur3/zipball/2.0.8/

But it came back as 404 Not Found

This may mean some online endpoint changed in an unexpected way, so if does not
seem like something on your side is causing this (e.g. firewall) please report
this to https://github.com/elm/compiler/issues with your operating system, Elm
version, the command you ran, the terminal output, and any additional
information that can help others reproduce the error!
github-actions[bot] commented 1 year ago

Thanks for reporting this! To set expectations:

Finally, please be patient with the core team. They are trying their best with limited resources.