elm / core

Elm's core libraries
http://package.elm-lang.org/packages/elm/core/latest
BSD 3-Clause "New" or "Revised" License
2.8k stars 359 forks source link

NOTE: The compiler provides the real implementation. #1108

Closed nilslindemann closed 3 years ago

nilslindemann commented 3 years ago

I like that ^ comment very much in String.elm, Basics.elm, Char.elm.

But some other of those 'mysterious' types with just one symbol on the right side of the equals sign do not have this comment:

-- Bytes.elm
type Bytes = Bytes

-- Platform.elm
type Program flags model msg = Program
type Task err ok = Task
type ProcessId = ProcessId

-- Cmd.elm
type Cmd msg = Cmd

-- Sub.elm
type Sub msg = Sub

-- File.elm
type File = File

-- Http.elm
type Body = Body
type Part = Part
type Expect msg = Expect
type Value = Value

-- VirtualDom.elm
type Node msg = Node
type Attribute msg = Attribute

Could we add the comments here too?

Also, (at least for me) it would be of interest to have a link to a document which explains what happens in these locations.

github-actions[bot] commented 3 years ago

Thanks for reporting this! To set expectations:

Finally, please be patient with the core team. They are trying their best with limited resources.

nilslindemann commented 3 years ago

Hm, ok, I just see I can do stuff like type Foo = Foo myself. I thought these right side things must refer to something which exists already. So this may just be a misunderstanding by me. But I am not sure, so for now I will refrain from closing it.

nilslindemann commented 3 years ago

Nah, I am closing it. I think I misunderstand something here. My apologies.