search

elm / elm-lang.org

Server and client code for the Elm website.
http://elm-lang.org/
BSD 3-Clause "New" or "Revised" License
1.99k stars 366 forks source link

Sanitize repository-url in namespaces #669

Closed hkjels closed 5 years ago

hkjels commented 7 years ago

Using . in the repository-url, except from the .git$-part will cause syntax-errors upon executing the code. That is, it will compile just fine, but break in the browser. Note that using .'s are quite usual as github-pages require them, so I believe this issue needs to be prioritized as it can put new users off.

For clarity, the url below would fail: "repository": "https://github.com/user/user.github.io.git"

I'm using Elm 0.18.0 and any modern browser will fail for any modern OS

process-bot commented 7 years ago

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

evancz commented 5 years ago

I'm not clear on what this means. I think it refers to something related to package.json which is not needed for building the site at this time.

hkjels commented 5 years ago

You're probably right. I'm having a hard time grasping the issue myself 😳 Sorry

evancz commented 5 years ago

No worries! This repo has changed a lot over time!