Add "ignoreResponseBody" expectation.

jonnyarnold commented 6 years ago

Based on #12, it's not obvious how to deal with empty response bodies.

I've added a new expectation to the Expect zoo which can be used to ignore a request body. This was do-able with expectString, but wasn't obvious and didn't have a representative type signature.

While doing this, I had a few questions:

I couldn't come up with a name for this that fit the Expect sentence pattern: I thought about calling it expectEmptyBody, but it doesn't actually do a check - it just ignores it. Any suggestions?
Should expect be a parameter to get and post? (Obviously this is a breaking change, but I wonder whether expecting JSON on all responses is too opinionated.)

Thanks for reading!

process-bot commented 6 years ago

Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

zwilias commented 6 years ago

I'd like to point out that this expectation exists in lukewestby/http-extra and is also implicitly used in lukewestby/elm-http-builder.

(Just presenting these as factual information relevant to the PR, not expressing an opinion on whether or not this makes sense to have in core)

jonnyarnold commented 6 years ago

@zwilias I didn't know about these packages - thanks :)

elm / http

Add "ignoreResponseBody" expectation. #35