elm / http

Make HTTP requests in Elm
https://package.elm-lang.org/packages/elm/http/latest
BSD 3-Clause "New" or "Revised" License
155 stars 46 forks source link

'GET' requests don't seem to include body #62

Open sxh opened 5 years ago

sxh commented 5 years ago

I am integrating an application with ElasticSearch, and the search query API relies on sending the query in a JSON body attached to a get request (see https://www.elastic.co/guide/en/elasticsearch/reference/current/query-filter-context.html for some examples).

I have been able to query the API this way from the command line using curl, and from Ruby using RestClient. When I try to do the same with Elm http the payload seems to get lost (I have checked the http request in Wireshark and compared it to the same request sent via Ruby).

The code used to set up the get request is shown below. The same code works as expected when I change the GET to POST, so I have a short term work around. Is dropping the payload on a GET request intended behaviour, or am I doing something wrong?

Http.request { method = "GET" , headers = [ Http.header "Accept" "application/json" ] , url = "https://(url here)/_search" , body = Http.jsonBody jsonBodyValue , expect = Http.expectJson SetProducts elasticSearchProductListDecoder , timeout = Nothing , tracker = Nothing }

The send functions and returns a response, but the contents of the response is the same as when there is intentionally no query payload.

Bernardoow commented 4 years ago

I want send get with body too.

speezepearson commented 4 years ago

See this Elasticsearch issue for much discussion of this -- tldr, "the specs" and "the things people actually do" appear to be in conflict here. (The top comment also suggests a couple workarounds for clients that don't support GET-with-body.) I'm not an expert, but it sounds like the bottom line is "GET-with-body is discouraged and only sketchily supported and should be avoided."

So, I suspect that this issue will get tagged wontfix, given how opinionated Elm is in general ;)

horriblename commented 10 months ago

I feel like this should be mentioned in the docs even if it's a wontfix