search

elm / parser

A parsing library, focused on simplicity and great error messages
https://package.elm-lang.org/packages/elm/parser/latest
BSD 3-Clause "New" or "Revised" License
228 stars 46 forks source link

No implementation for deadEndsToString #9

Open jdmnd opened 6 years ago

jdmnd commented 6 years ago

https://github.com/elm/parser/blob/master/src/Parser.elm#L170 The documentation implies a basic working implementation, but currently it's just a placeholder:

deadEndsToString deadEnds =
  "TODO deadEndsToString"
blawlor commented 5 years ago

I've created a PR with a proposed implementation for this function. All comments welcome.

bburdette commented 5 years ago

I too have a PR for this issue, which has been sitting since september!

blawlor commented 5 years ago

Hi @bburdette - I didn't see your PR on this ticket. If I had I would happily just have used your fork!

blawlor commented 5 years ago

Ok - I see what happened. Your PR is associated with a closed duplicate (#16 ) of this issue. Anyhoo - to the commiter(s) on this project, please use @bburdette 's PR over mine.

bburdette commented 5 years ago

Its ok with me either way! Would be nice for this to get merged sometime though. Maybe a major revision of the lib is waiting in the wings though.

andys8 commented 5 years ago

https://elmlang.slack.com/archives/C0CJ3SBBM/p1557003208085000?thread_ts=1557003208.085000&cid=C0CJ3SBBM

harrysarson commented 5 years ago

Same as above but copied into a gist for folk reading this in more than two weeks time: https://gist.github.com/harrysarson/234436a9f0517e14d0fd67fd63ba6619

Erudition commented 5 years ago

Yikes. Still just a TODO...