Only divert href to app if there is an href for an anchor tag.

elm / virtual-dom

The foundation of HTML and SVG in Elm.

https://package.elm-lang.org/packages/elm/virtual-dom/latest

BSD 3-Clause "New" or "Revised" License

209 stars 80 forks source link

Only divert href to app if there is an href for an anchor tag. #142

Open Pilatch opened 5 years ago

Pilatch commented 5 years ago

Addresses issue raised at https://github.com/elm/browser/issues/34 which appears to check out, when you take a look at the HTML specification.

AntonLebiodkin commented 5 years ago

When it could be merged?

Pilatch commented 5 years ago

Good question. I'm not sure exactly what Elm's open-source workflow is.

jarlah commented 4 years ago

This has to be fixed. And no attention for 1 year ? Like really ? it would be pretty much useless to use Elm if it is not ignoring anchor links. Not all code is coded. What if i use a markdown plugin ?

Pilatch commented 4 years ago

@Skinney (Robin Heggelund Hansen)

I hear 20% of your job is working on Elm. Maybe this PR would be a quick win? :)

berzi commented 4 years ago

Commenting here to make some more noise and letting people know we care about this PR. :)

Ja-rek commented 4 years ago

What about merge?

mmalter commented 2 years ago

Pretty please.