search

elm / virtual-dom

The foundation of HTML and SVG in Elm.
https://package.elm-lang.org/packages/elm/virtual-dom/latest
BSD 3-Clause "New" or "Revised" License
209 stars 80 forks source link

Trying to figure out how to test with this patch applied but Kernel code means I'm stuck :/ #177

Closed erlandsona closed 2 years ago

erlandsona commented 2 years ago

Help please 🙏

evancz commented 2 years ago

I am not sure the goals here exactly, but I suspect there'll be people on the Elm discourse or Slack that can give pointers on your question.

erlandsona commented 2 years ago

@evancz I ended up using https://github.com/robx/shelm to vendor in the patches to the lib to make virtual-dom play nice with Grammarly. I found the solution after I found https://discourse.elm-lang.org/t/runtime-errors-caused-by-chrome-extensions/4381 Which is a fairly detailed explanation of the issues along with some patched forks of elm/virtual-dom which we ended up vendoring into our CI process via https://github.com/robx/shelm Which subsequently caused issues with my co-workers trying to setup LSP in their editors for Elm.

Only elaborating on this because an 0.19.2 with some of these patches applied would enable us to eliminate a lot of bespoke tooling that's caused us a good deal of headache 😞

Still lovin' Elm tho! 🙌