SmtpClient is not being correctly disposed of

[bartuszekj]

SmtpClient implements IDisposable as of .NET 4.0. ErrorMailModule.SendMail method does not correctly dispose of its SmtpClient. This causes the smtp connection to hang for an extended amount of time. Added benefit of properly closing/disposing of the SmtpClient instance is that an smtp QUIT command can be properly sent to the server.

To maintain compatibility between .NET versions, I suggest implementing the following solution:

var client = new SmtpClient();

using (client as IDisposable) // allow client not to implement IDisposable, but correctly handle the 4.0+ implementation
{
   // ... do all the SmtpClient work
   client.Send(mail);
}

[atifaziz]

@bartuszekj Thanks for bringing this up! Do you want to try and submit a PR against the 1x branch with the compatible change you proposed?

[bartuszekj]

Done. It did create a new issue for this, though (#401).

[atifaziz]

Merged & closed by 6861de61ddf80000e7204cd976418bd771921ccc

Thanks! Should be in the next service pack release.