search

elmah / Elmah

Error Logging Modules & Handlers for ASP.NET
https://elmah.github.io/
Apache License 2.0
306 stars 65 forks source link

Implementing a feature to delete old files based on the size parameter #405

Closed marcusvnac closed 4 years ago

marcusvnac commented 7 years ago

Implementing a feature to delete old XML files based on the size parameter.

djsmith commented 7 years ago

Would this get into a loop of trying to delete a log, throwing an exception for some reason, which would then cause Elmah to create a new log, calling the DeleteOldFiles function, and then failing again?

marcusvnac commented 7 years ago

Hi @djsmith , looking at the code I believe that this problem could happen. Any suggestions?

djsmith commented 7 years ago

Yea, I have some ideas, I'll put together a pull request for you.

marcusvnac commented 7 years ago

Great @djsmith ! Who knows after that @atifaziz could accept this code to be merged into main code.