search

elmahio / Elmah.Io.ElasticSearch

Elmah.Io.ElasticSearch is an Elasticsearch storage backend for ELMAH.
https://elmah.io
Apache License 2.0
23 stars 8 forks source link

CI Build improvements #53

Closed jayhilden closed 8 years ago

jayhilden commented 8 years ago
  1. Ensure support for .NET 4.6.1
  2. Support C# 6 syntax
  3. Support CI build on branches that publish -prerelease candidates to Nuget
jayhilden commented 8 years ago

@ThomasArdal if you'd like to switch to Appveyor that's fine, I've not used it before. I put in the 3 things that would be nice to support. If Appveyor is a better solution than TC I'm cool with that.

ThomasArdal commented 8 years ago

@jayhilden I have a build running here: https://ci.appveyor.com/project/ThomasArdal/elmah-io-elasticsearch. Maybe we should try to create a c# 6 branch or something and let Appveyor build that.

I noticed that the TeamCity project is configured to build using MSBuild for .NET 4.0. Build Tools 2015 is an option as well. Maybe swithing to that, will make it build the C# 6 code. Do you have access to the settings on TC?

jayhilden commented 8 years ago

@ThomasArdal this branch now has the C# 6 stuff that doesn't compile in TC.

https://github.com/elmahio/Elmah.Io.ElasticSearch/tree/feature/CSharp6

I don't have access to the TC settings, if you give me access to change the settings I can probably take care of all the items on this story.

ThomasArdal commented 8 years ago

@jayhilden Could you create a user here: http://teamcity.codebetter.com/? I will ask CodeBetter to add you as admin.

jayhilden commented 8 years ago

@ThomasArdal username is

ThomasArdal commented 8 years ago

@jayhilden I have asked the CodeBetter folks to add you :)

ThomasArdal commented 8 years ago

@jayhilden You should now have access

jayhilden commented 8 years ago

Thanks @ThomasArdal looks like I'm in. I'll play a bit with TC and with AppVeyor to see which one makes the most sense. TC is great, but the host seems really overloaded, just loading the config page takes like 30 seconds.

jayhilden commented 8 years ago

@ThomasArdal I've got a 2.0 RC building in Appveyor here. The next step is to have it publish from AppVeyor to Nuget. Is that something that you can give me rights to setup or that you would need to do? My AppVeyor account is linked to my github account if you'd like to give me access.

Ideally this would be the configuration:

I've tried to setup that pre-release naming convention using a appveyor.yml file and that indeed did work for the Appveyor build number, not sure how that exactly maps to nuget.

Thanks for the help!!

ThomasArdal commented 8 years ago

@jayhilden It looks like you will be able to admin all of my projects, if I add you to the team on AppVeyor. But you can specify everything in appveyor.yml and I can generate an encrypted API key in order to be able to push to NuGet.

jayhilden commented 8 years ago

Great, if you can get me the encrypted key I'll try it out.

On Tue, Sep 20, 2016, 10:32 PM Thomas Ardal notifications@github.com wrote:

@jayhilden https://github.com/jayhilden It looks like you will be able to admin all of my projects, if I add you to the team on AppVeyor. But you can specify everything in appveyor.yml and I can generate an encrypted API key in order to be able to push to NuGet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elmahio/Elmah.Io.ElasticSearch/issues/53#issuecomment-248502114, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNyEf8B03h8QhjXSTm_y3wil3Uw2lkBks5qsKVYgaJpZM4Hbkve .

ThomasArdal commented 8 years ago

@jayhilden I can do that. But thought about something else. Maybe I should just add you as an owner of that NuGet package. Would make sense, right? Then you can publish updates to that package as well. Using your API key and https://ci.appveyor.com/tools/encrypt.

jayhilden commented 8 years ago

That would be even better. My username on nuget is jhilden.

How about we go one step further too and remove your appveyor build and I'll add my own. I actually already did that but I noticed that's it picking up the changes into your project but not mine.

So 2 changes total:

  1. Make jhilden an owner of the project on nuget
  2. Remove the project from your appveyor account

Thanks for such a quick response.

On Tue, Sep 20, 2016, 10:47 PM Thomas Ardal notifications@github.com wrote:

@jayhilden https://github.com/jayhilden I can do that. But thought about something else. Maybe I should just add you as an owner of that NuGet package. Would make sense, right? Then you can publish updates to that package as well. Using your API key and https://ci.appveyor.com/tools/encrypt.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elmahio/Elmah.Io.ElasticSearch/issues/53#issuecomment-248503923, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNyEaMlxERAFL0y5UGlpjmDfaXaFcgAks5qsKi9gaJpZM4Hbkve .

ThomasArdal commented 8 years ago

@jayhilden Both done 😄

jayhilden commented 8 years ago

@ThomasArdal one more thing I need: I need to be an admin on this github repo so that I can add the webhooks. I think I'm good everywhere else.

ThomasArdal commented 8 years ago

@jayhilden You should now be admin.

jayhilden commented 8 years ago

@ThomasArdal thanks Thomas, new hook is in place and working!

jayhilden commented 8 years ago

@ThomasArdal thank you for all your help on this. And thank you for asking the question below about the prerelease, that took me a while to figure out. I wish that was on stackoverflow so I could give you some points for it!

http://help.appveyor.com/discussions/problems/2626-building-prerelease-nuget-package

ThomasArdal commented 8 years ago

@jayhilden Always a pleasure :smile: