elmarti / react-joystick-component

Tiny, multitouch, component driven joysticks in react
MIT License
86 stars 27 forks source link

GitHub actions not resolving directory in Deploy Storybook step #49

Closed elmarti closed 1 year ago

elmarti commented 1 year ago

The Storybook deploy was already broken and I moved it into a separate step for clarity. It seems to be unable to resolve the project

Post refactor https://github.com/elmarti/react-joystick-component/actions/runs/3505460383 https://github.com/elmarti/react-joystick-component/actions/runs/3505438482 https://github.com/elmarti/react-joystick-component/actions/runs/3505419843 https://github.com/elmarti/react-joystick-component/actions/runs/3505396544 https://github.com/elmarti/react-joystick-component/actions/runs/3505386212 https://github.com/elmarti/react-joystick-component/actions/runs/3505382455

Pre refactor https://github.com/elmarti/react-joystick-component/actions/runs/3364862815 https://github.com/elmarti/react-joystick-component/actions/runs/3364931701 https://github.com/elmarti/react-joystick-component/actions/runs/3505337935 https://github.com/elmarti/react-joystick-component/actions/runs/3505376297 https://github.com/elmarti/react-joystick-component/actions/runs/3505382455

elmarti commented 1 year ago

Removed the separate job for storybook build, reverted back to the original issue of storybook deploy not working - turns out fixing node to 16 fixed this. Opening an issue on the deploy repo

Fix: https://github.com/elmarti/react-joystick-component/commit/a3f69fcdda0de693b7e62e5646b8b0aa175a592c

Pre Node 16 build failure: https://github.com/elmarti/react-joystick-component/actions/runs/3542219777/jobs/5947453550

elmarti commented 1 year ago

I take that back, it could be related to @storybook/react being out of date