search

elmarti / react-joystick-component

Tiny, multitouch, component driven joysticks in react
MIT License
86 stars 27 forks source link

:bug: Change event handlers from anonymous functions so they can be propery removed #61

Closed drittman closed 1 year ago

drittman commented 1 year ago

removeEventListener() is not removing the listener for the reason outlined here: https://stackoverflow.com/questions/10444077/javascript-removeeventlistener-not-working

elmarti commented 1 year ago

Tested - all looks good. Thanks for the commit!

Out of interested, how did you find this bug?

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

drittman commented 1 year ago

Thanks for being so prompt! I use this component in an app to control PTZ cameras. There are other drag-and-drop interactions in the app. In Chrome, after moving the joystick, none of the other drag-and-drop interactions worked. Strangely, they still did work in Firefox (which I can't really explain). In Chrome dev tools, there is a tab to view Event Handlers and it was clear that the move handler was not being removed after using the joystick.

On Thu, May 25, 2023 at 2:26 AM Jack @.***> wrote:

Tested - all looks good. Thanks for the commit!

Out of interested, how did you find this bug?

— Reply to this email directly, view it on GitHub https://github.com/elmarti/react-joystick-component/pull/61#issuecomment-1562349075, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANIGYGOPPSE7QOHRUTSDBXDXH33R3ANCNFSM6AAAAAAYNNPDXU . You are receiving this because you authored the thread.Message ID: @.***>

-- Dan Rittman Co-founder @.*** 317-371-1714