search

elmcraft / core-extra

Utility functions for an improved experience with elm/core
https://package.elm-lang.org/packages/elmcraft/core-extra/latest/
Other
23 stars 11 forks source link

Fixed: Adjust underscored tests to match dasherize #10

Closed ahankinson closed 1 year ago

ahankinson commented 1 year ago

The tests for underscored and dasherize were very similar, and dasherize relies on underscored to function.

So the tests for each of them were aligned. This also fixes a failure with the existing underscored test.

ahankinson commented 1 year ago

Yeah, I thought about that, but there doesn't seem to be a common "Test Utilities" module already, so I'd have to create a new one. Would that be OK? Or some other place I can add it?

gampleman commented 1 year ago

Or perhaps you can just collect both of those tests into a single module?

ahankinson commented 1 year ago

Also possible! I'll do that. I guess we can close this one, then?

gampleman commented 1 year ago

However you like to do it.

ahankinson commented 1 year ago

Fixed in #12