Closed Janiczek closed 8 months ago
@Janiczek tests are failing, can you fix them?
@miniBill Sorry, no I won't:
Maybe best to close this PR? It served a purpose of finding out what the situation is with the -->
doc comments: it's going to be a non-trivial amount of work to fix those.
Ah, sorry, I had missed that. I think it makes sense to keep it open! Doc tests should not be broken!!!
I've added a commit that fixes the tests, so I think we can now merge this, right?
This makes the doc tests in
String.Extra
runnable. Unfortunately it also shows that some of them are failing (see below).I think the failures are a mix of code being wrong and tests being wrong. Some hammock time might be needed to figure out what the expected behaviour of those functions is supposed to be.
@gampleman Just for transparency, I am not planning to fix these - I just tried the
==
➡️-->
change in case it was non-problematic. Ultimately it wasn't, but I hope my commit here will save you or anybody picking up this work, some of the work.