search

elmish / Elmish.WPF

Static WPF views for elmish programs
Other
421 stars 68 forks source link

Combine Seq.map and Seq.iter #564

Closed LyndonGingerich closed 1 year ago

LyndonGingerich commented 1 year ago

Cleanup after #563

LyndonGingerich commented 1 year ago

That commit message doesn't make as much sense to me, but I changed it.

TysonMN commented 1 year ago

I thought the previous commit message was referring to the implementations of those functions. Of course I now see that isn't possible (since we didn't implement those functions).

Another commit message that is not similar to your first one that I think is clear would be

Inline Seq.map argument into Seq.iter argument

LyndonGingerich commented 1 year ago

Better?

On Thu, May 11, 2023 at 12:52 AM Tyson Williams @.***> wrote:

I thought the previous commit message was referring to the implementations of those functions. Of course I now see that isn't possible (since we didn't implement those functions).

Another commit message that is not similar to your first one that I think is clear would be

Inline Seq.map argument into Seq.iter argument

— Reply to this email directly, view it on GitHub https://github.com/elmish/Elmish.WPF/pull/564#issuecomment-1543377838, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGPJBTKGRTTFJKW32ZWT43XFR5BXANCNFSM6AAAAAAX2KDR5U . You are receiving this because you authored the thread.Message ID: @.***>