elmish / debugger

Time-traveling debugger and import export for Elmish apps
https://elmish.github.io/debugger
Other
41 stars 10 forks source link

No UI refresh when travel debug / replay is enabled. #62

Open zpodlovics opened 1 year ago

zpodlovics commented 1 year ago

Description

No UI refresh when travel debug / replay is enabled.

Repro code

1) Create a new awesome app using the elmish template as of https://github.com/elmish/templates 2) Install redux devtools extension (firefox in my case)

Expected and actual results

Expected result: UI refresh.

Actual result:

The counter value should be 0 in this case.

Screenshot from 2023-07-30 21-57-21

Related information

paket.lock.zip

It seems that the interaction between the components are complicated especially when react and stores are involved. Would it be impossible to provide a way to refresh the ui (functionality) for the debugger?

et1975 commented 1 year ago

Thanks for the report! I don't recall if I ever tried this in FF. It's possible some security feature is interfering with the plugin. What is that angry red icon in the status bar? Could you try this in opera/chrome/edge as well? Does it work with standalone DevTools?

zpodlovics commented 1 year ago

The angry red icon on the status bar is the missing favicon. Screenshot from 2023-08-06 16-39-23

I also checked it with chrome (fresh install, only redux devtools installed):

Screenshot from 2023-08-06 16-40-30

And edge as well (fresh install, only redux devtools installed):

Screenshot from 2023-08-06 16-41-07

Checking it with standalone devtools is works in progress.

et1975 commented 1 year ago

I just tried the debugger on our ToDo sample and it works as expected. Looking at the template code I think |> Program.withReactBatched and |> Program.withDebugger are in reverse order. @zpodlovics please flip the order of these 2 instructions and try again? If that does it please open a PR into the template repo to fix this!