elmish / hmr

Hot Module Replacement for Elmish apps
https://elmish.github.io/hmr
Other
28 stars 9 forks source link

Latest release has a dependency on FSharp.Core 5.0.2 #34

Closed alfonsogarciacaro closed 2 years ago

alfonsogarciacaro commented 2 years ago

This triggers warnings when restoring from an app using a lower dotnet SDK version.

alfon@LAPTOP-V7RGQGT0 MINGW64 ~/repos/Fable.Lit/sample (main)$ dotnet restore
  Determining projects to restore...
C:\Users\alfon\repos\Fable.Lit\sample\Sample.fsproj : warning NU1605: Detected package downgrade: FSharp.Core from 5.0.2 to 5.0.0. Reference the package directly from the project to select a different version.
C:\Users\alfon\repos\Fable.Lit\sample\Sample.fsproj : warning NU1605:  Sample -> Fable.Elmish.HMR 4.3.0 -> FSharp.Core (>= 5.0.2)
C:\Users\alfon\repos\Fable.Lit\sample\Sample.fsproj : warning NU1605:  Sample -> FSharp.Core (>= 5.0.0)
  All projects are up-to-date for restore.

I'm still confused by this but I think if you add <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference> to the .fsproj PropertyGroup you don't even need the FSharp.Core dependency for libraries (e.g. Fable.AST has no dependencies). Or you can just specify a low FSharp.Core version like 4.7.2.