search

elmish / hmr

Hot Module Replacement for Elmish apps
https://elmish.github.io/hmr
Other
28 stars 9 forks source link

WIP: Support elmish 4 #38

Closed MangelMaxime closed 2 years ago

MangelMaxime commented 2 years ago

~Yesterday when releasing 6.0.0-beta-001 I think HMR was working.~

~But after rebasing this branch on the latest version of master, it seems like something is broken. I am investigating the problem.~

Ok, in fact I forgot to add a line of code so the beta-001 actually never worked.

Next, step is to take a look at supporting several Elmish application.

MangelMaxime commented 2 years ago

@et1975 This PR is ready for review.

Your comment disappeared because I re-base the PR.

Your comments was:

  1. Is the formatting that I use easier to read or not?

Personally, I like it because the declaration, update side of the record is consistent everywhere. But if you prefer another format please feel free to tell me or update the PR and I will follow it on the other website.

  1. Use dotnet add package instruction instead of dotnet paket add.

Changes has been done.

  1. Should we use a workflow to auto publish?

I did set up a workflow to publish the website when a commit occurred on the default branch. I couldn't test the workflow yet, because this PR is not in the default branch yet.

When accepted, I will check the workflow and fix it if needed.

I am going to prepare the documentation for the other project, in order to have the same style everywhere. I believe, we should wait for all the website to be ready before merging this PR in.

MangelMaxime commented 2 years ago

I can't find a way to support multiple Elmish instance for HMR.

For now, I just added a warning about it in the documentation.