WIP Fable/Elmish v4 upgrade

elmish / hmr

Hot Module Replacement for Elmish apps

https://elmish.github.io/hmr

Other

28 stars 9 forks source link

WIP Fable/Elmish v4 upgrade #41

Closed kspeakman closed 1 year ago

kspeakman commented 1 year ago

resolves #40

Status
Compiles	✔️
Tests work	✔️
Docs build	❌

TODO

[x] broken dep: Tests proj, nuget Feliz.Bulma -> Fable.React, needs to be Fable.ReactDom etc Options
- A: wait for Felize.Bulma beta with latest Fable React libs
- B: remove dependency for now, change views to use Bulma CSS
- C: other suggestions?
- [ ] broken dep: docs, npm Nacara -> React v17, other libs require v18

kspeakman commented 1 year ago

@MangelMaxime Is it possible to isolate the Nacara deps from the Test project deps? Was thinking it might be possible to have it in a separate folder with its own package.json. I'm not practiced in advanced front-end build scenarios.

MangelMaxime commented 1 year ago

Sorry, I didn't see that you took into account some of my comments and so was still waiting for after you... (my bad)

I will have a look at the dependencies stuff.

In theory, React 18 is compatible with React 17 with some warning.

kspeakman commented 1 year ago

No worries!

Ah, yes. I seem to be using React 18 with the older Fable.React package and see a warning on every render. I think this works because Fable.React is dotnet and can't enforce npm package deps. Could Nacara's npm deps be changed to allow both v17 and v18?

MangelMaxime commented 1 year ago

Supporting both react 17 and 18 is not that easy, because some import needs to be different.

I am just going to support React 18 for now. Nacara is under a complete rewrite right now, to delegate most a lost of responsibility to an external tool so I can focus on what make add values to Nacara (providing a good template for documentation + F# API generation in the future)