search

elmish / hmr

Hot Module Replacement for Elmish apps
https://elmish.github.io/hmr
Other
28 stars 8 forks source link

unable to get HMR working for SAFE-Nightwatch #6

Closed ctaggart closed 6 years ago

ctaggart commented 6 years ago

I can't get HMR working with the SAFE-Nightwatch demo app: https://github.com/SAFE-Stack/SAFE-Nightwatch/issues/50. I provided a YouTube video. I also tried updating Gradle, the Android plugin, and React Native without luck.

MangelMaxime commented 6 years ago

@forki Did you get HMR working with RN ?

Last time I heard about it, we was not able to support it. Is it still the case ?

forki commented 6 years ago

yes HMR worked fine. but something broke very recently. I'm bisecting rigth now. see that other issue

forki commented 6 years ago

ok this can be closed. found the root cause.

forki commented 6 years ago

one questio is: can we make lazyView2 work with HMR? In other words could the HMR module hijack that function and make it non-lazy? // @et1975

MangelMaxime commented 6 years ago

@forki Someone that here https://github.com/fable-elmish/react/issues/22

I am not sure of the direction to take.

IMO, if someone need to use lazyView then even in dev mode we need to have it active otherwise how would you check the final user experience.

But as I don't use them (yet), I don't have a lot of experience with it..