search

elmish / react

Elmish React extensions for writing SPA and Native apps
https://elmish.github.io/react
Other
104 stars 21 forks source link

Use Fable.React.Types dependency #68

Closed alfonsogarciacaro closed 2 years ago

alfonsogarciacaro commented 2 years ago

@et1975 @MangelMaxime With the release of Fable 4, users will have to update some packages so it's a good time to do some cleanup (we should also take the chance to release Elmish 4 as stable). We've been discussing for some time to split Fable.React into a types package containing only bindings (as with the Browser packages) and another containing the helpers. This prevents that packages like Feliz need to take the full Fable.React dependency only for compatibility.

Are you ok with this change? If so, would it be possible to push a beta release? Thanks a lot!

Note: I've also tried to improve the project metadata for publishing by using string interpolation in the build script, replace the deprecated tags (PackageIconUrl, PackageLicenceUrl) and add the README file, but I'm not sure if it works correctly. Could you please check?

et1975 commented 2 years ago

Thanks Alfonso, approve in principle, but the build.fsx needs to be fixed.

alfonsogarciacaro commented 2 years ago

Ups, that's why I should build locally before sending the PR 😅 Thanks @et1975!

et1975 commented 2 years ago

Released as 4.0.0-beta-3, thanks Alfonso!