elmoiv / redvid

Smart downloader for Reddit hosted videos
GNU General Public License v3.0
110 stars 15 forks source link

small changes #2

Closed E-G-C closed 4 years ago

E-G-C commented 4 years ago

-mux_all defaults to video file if not new video is created -download return video path after download,

elmoiv commented 4 years ago

Thanks for your contribution!

I am planning now to convert videos without audio via ffmpeg too. Problem is those videos have a codec that prevents you from sharing them through some applications and platforms.

elmoiv commented 4 years ago

Note that you should use the global formatting not Python 3.6+ formatting to make the project available for Python 3.x users.

Always use "{}".format(s) instead of f"{s}". I already updated your pull request.

E-G-C commented 4 years ago

guilty 😔...haven't targeted anything lower than 3.6 in a while