search

elnabo / json2object

Type safe Haxe/JSON (de)serializer
MIT License
66 stars 17 forks source link

Haxe 4 / dev branch support #26

Closed Gama11 closed 7 years ago

Gama11 commented 7 years ago

Because of https://github.com/HaxeFoundation/haxe/pull/6380, json2object needs an update to support Haxe 4. Ideally, the haxe_ver defines is checked (example) to support both Haxe 4+ and 3.4.

ibilon commented 7 years ago

Tried in https://github.com/elnabo/json2object/commit/07e52e08d73cbd85f35deb6f0097aac13db5d520, it fixes the issue but I'm seeing some inconsistencies in the tests on different targets. Some say null should 0 or null should be [] but not all.

Also is the haxe_ver check necessary? There's either the null abstract or null typedef, so there shouldn't be any conflict in checking both.

Gama11 commented 7 years ago

Hm, right, might not be necessary.

ibilon commented 7 years ago

Done in https://github.com/elnabo/json2object/commit/6d0c25e6855cb05a32e31ccd3b336bf062d145eb

Gama11 commented 7 years ago

Hm, something seems to be broken.. will look into it later. https://travis-ci.org/vshaxe/vshaxe#L677

Gama11 commented 7 years ago

Nvm, that was actually an issue with the macros in haxe-formatter, which also needed an update.