elnook / notedo

Notes, Todos, Markdown, Bookmarks and more with VIM support and full-text search - stay'in organized
5 stars 0 forks source link

possible upgrade bug #12

Closed cmeinco closed 3 years ago

cmeinco commented 3 years ago

Describe the bug error on upgrade

To Reproduce Steps to reproduce the behavior: notedo@notedoserver:/opt/notedo$ ./notedo upgrade

2020/11/25 14:59:27 New version available `0.1.8-7-gdba1ef9` (current `0.1.8`)
2020/11/25 14:59:27 Downloading: https://github.com/elnook/notedo/releases/download/0.1.8-7-gdba1ef9/notedo-linux-0.1.8-7-gdba1ef9.tar.gz
2020/11/25 14:59:32 Created backup of current binary at: /opt/notedo/.notedo/backup/bin/notedo-0.1.8.tar.gz
2020/11/25 14:59:32 Swapping in new binary...
2020/11/25 14:59:32 Error upgrading: Unable to unzip downloaded archive: zip: not a valid zip file
  1. Ran upgrade again but says it did complete the upgrade:
    notedo@notedoserver:/opt/notedo$ ./notedo upgrade
    2020/11/25 15:02:46 Already up to date: 0.1.8-7-gdba1ef9

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here (screenshots, files, etc.)

image

Running tar xvzf notedo-linux-0.1.8-7-gdba1ef9.tar.gz worked fine.

davidwashere commented 3 years ago

yeup, that is indeed a bug, will be fixed in release later today. Thanks!

davidwashere commented 3 years ago

This is fixed in 0.1.9+, will need to do the upgrade manually (ie: untar the .tar.gz and replace the executable)

davidwashere commented 3 years ago

Fixed