search

elnopintan / gorgone

Bringing persitent collections to c++
5 stars 2 forks source link

a few thoughts #1

Open sandover opened 12 years ago

sandover commented 12 years ago

It looks like PersistentVector is mostly a faithful port of Rich's java code; where did RRBVector come from?

One thing you might consider performance-wise: dynamic_cast is a fairly slow operation. Since you're confident that your casts won't blow up, you could convert those calls to static_cast. I tried this and at least for the test code, it works fine.

What are your plans for this library?

elnopintan commented 12 years ago

I got tired a bit early of this project. Thank you for your interest. RRB trees are from this paper. http://infoscience.epfl.ch/record/169879/files/RMTrees.pdf Feel free to fork it. I don't think I'll resume it any time soon

sandover commented 12 years ago

Forked! What's the protocol -- should I change the project's name?

On Jun 3, 2012, at 5:35 AM, Ignacio Blasco Lópezreply@reply.github.com wrote:

I got tired a bit early of this project. Thank you for your interest. RRB trees are from this paper. http://infoscience.epfl.ch/record/169879/files/RMTrees.pdf Feel free to fork it. I don't think I'll resume it any time soon El 03/06/2012 00:05, "Brandon Harvey" < reply@reply.github.com> escribió:

Reply to this email directly or view it on GitHub: https://github.com/elnopintan/gorgone/issues/1#issuecomment-6085138

elnopintan commented 12 years ago

As you wish. Only some acknowledgement if you wish El 05/06/2012 18:25, "Brandon Harvey" < reply@reply.github.com> escribió:

Forked! What's the protocol -- should I change the project's name?

On Jun 3, 2012, at 5:35 AM, Ignacio Blasco Lópezreply@reply.github.com wrote:

I got tired a bit early of this project. Thank you for your interest. RRB trees are from this paper. http://infoscience.epfl.ch/record/169879/files/RMTrees.pdf Feel free to fork it. I don't think I'll resume it any time soon El 03/06/2012 00:05, "Brandon Harvey" < reply@reply.github.com> escribió:

Reply to this email directly or view it on GitHub: https://github.com/elnopintan/gorgone/issues/1#issuecomment-6085138

Reply to this email directly or view it on GitHub: https://github.com/elnopintan/gorgone/issues/1#issuecomment-6129416

sandover commented 12 years ago

Would you like to actually transfer this project's ownership to me?

elnopintan commented 12 years ago

Better not. I prefer if you fork it. El 19/06/2012 19:57, "Brandon Harvey" < reply@reply.github.com> escribió:

Would you like to actually transfer this project's ownership to me?

Reply to this email directly or view it on GitHub: https://github.com/elnopintan/gorgone/issues/1#issuecomment-6432604