cashurpc - Githubissues

gohumble commented 7 months ago

resolved changes from @callebtc todo:

[ ] add removed .env.wallet.example
[x] refactor MINT_CONTACT_INFO ?
[ ] test mint using https://cashu.me
[ ] add Dockfile

elnosh commented 7 months ago

2. refactor MINT_CONTACT_INFO ?

to what does it need to change?

gohumble commented 7 months ago

Tthe contact infos currently defined as an array of arrays with at most 2 elements. The first element represents the key, while the second element is the value. This should probably be update to an array of objects.

current state:

"contact": [
    ["email", "contact@me.com"],
    ["twitter", "@me"],
    ["nostr" ,"npub..."]
  ]

desired state (already implemented in this PR)

  "contact": [
    {"type":"email", "value":"contact@me.com"},
    {"type":"twitter", "value":"@me"},
    {"type":"nostr" , "value":"npub..."}
  ]

I am going to open a new pull request in the nuts repository and propose the change to the protocol there.

gohumble commented 7 months ago

https://github.com/cashubtc/nuts/pull/117

elnosh / gonuts

cashurpc #6