search

elodina / go-avro

Apache Avro for Golang
http://elodina.github.io/go-avro/
Apache License 2.0
129 stars 55 forks source link

GenericDatum: Using long to represent string length in BinaryDecoder. #33

Closed arunmk closed 9 years ago

arunmk commented 9 years ago

Currently BinaryEncoder uses long (int64) and BinaryDecoder uses int (int32). Avro spec asks us to use long.

arunmk commented 9 years ago

This is fixed by: Pull: https://github.com/stealthly/go-avro/pull/37 Commit: https://github.com/arunmk/go-avro/commit/44744fb68a84ce7c308cde333c51ee2cc7bc6374

This is tough to test as both types are represented by variants and we would need a huge string to fail the max buffer check. Hence there is no test updated.