search

elodina / go-avro

Apache Avro for Golang
http://elodina.github.io/go-avro/
Apache License 2.0
129 stars 55 forks source link

Add String() method to GenericRecord #40

Closed i closed 9 years ago

i commented 9 years ago

Since GenericRecord.fields is unexported, it's difficult to do this outside of the library. It might be just as useful to export the makeMap method as well. I'm curious if you all agree.

Thanks for looking!

serejja commented 9 years ago

Hi, sorry for taking so long to answer. I think we can merge this once you fix the thing I commented in.

Thanks!

i commented 9 years ago

Hi @serejja -- made some changes. Can you review again?