search

elodina / go_kafka_client

Apache Kafka Client Library for Go
http://www.elodina.net
Apache License 2.0
275 stars 74 forks source link

Panic thrown when Zookeeper Node Restarts #156

Closed carnellj closed 9 years ago

carnellj commented 9 years ago

Hi guys,

Here is the situation. We are using the GO Kafka Client to create a consumer listening to kafka. Our DevOps was doing a rolling upgrade to the Zookeeper cluster that our Kafka cluster uses. When the zookeeper node that the client listens to went down, we errors being written out that the server was unavailable, but out service stayed up and at least to process connections.

However, when the Zookeeper node that was down restarted the GO_Kafka Client threw a Panic at we traced the problem back to the zk_coordinator.go trySubscribeForChanges()'s function. Here is the specific part of the trace we tracked it down to.

* github.com/stealthly/go_kafka_client.func·050() /Users/matt.durham/repos/edge-proxy/src/github.com/stealthly/go_kafka_client/zk_coordinator.go:528 +0x992 created by github.com/stealthly/go_kafka_client.(_ZookeeperCoordinator).trySubscribeForChanges /Users/matt.durham/repos/edge-proxy/src/github.com/stealthly/go_kafka_client/zk_coordinator.go:562 +0xbdb _

Is this a bug or is this expected behavior? It seems like the consumer is tied to a specific zookeeperConnection and does not refresh after the connection has been re-established. Any help here would be greatly appreciated.

serejja commented 9 years ago

Hi @carnellj

Can you please try #159 and reply if this works for you?

Thanks!

serejja commented 9 years ago

@carnellj can we close this?

carnellj commented 9 years ago

Yes. Thank you for the help.

Sent from my iPhone

On Sep 24, 2015, at 2:07 PM, Serhey Novachenko notifications@github.com wrote:

@carnellj can we close this?

— Reply to this email directly or view it on GitHub.