Rename ZookeeperTimeout to ZookeeperSessionTimeout

elodina / go_kafka_client

Apache Kafka Client Library for Go

http://www.elodina.net

Apache License 2.0

275 stars 74 forks source link

Rename ZookeeperTimeout to ZookeeperSessionTimeout #190

Closed yudai closed 8 years ago

yudai commented 8 years ago

It's not actually a read timeout. If this value is not enough large, ephemeral nodes will be deleted while reconnecting to another ZK node when the leader ZK node goes down.

serejja commented 8 years ago

Ok, while this is actually a breaking change, I still think it makes sense in order to avoid confusion while configuring the consumer. Please fix the place I commented at and I will happily merge your PR. Thanks!

yudai commented 8 years ago

Thanks! Fixed the inconsistent name.

serejja commented 8 years ago

Merged. Thanks!