search

elodina / go_kafka_client

Apache Kafka Client Library for Go
http://www.elodina.net
Apache License 2.0
275 stars 74 forks source link

Install Error: #194

Closed miketonks closed 8 years ago

miketonks commented 8 years ago

Installing go_kafka_client gives errors. There's a breaking change in siesta-producer that removes input parameters to producer.Close()

$go get github.com/elodina/go_kafka_client

github.com/elodina/go_kafka_client

elodina/go_kafka_client/log_emitters.go:137: too many arguments in call to k.producer.Close elodina/go_kafka_client/mirror_maker.go:125: too many arguments in call to producer.Close elodina/go_kafka_client/testing_utils.go:154: too many arguments in call to p.Close elodina/go_kafka_client/testing_utils.go:178: too many arguments in call to p.Close

is caused by:

https://github.com/elodina/siesta-producer/commit/94fa7677332126e9eaca87ebc95727e6b3ed52b6

miketonks commented 8 years ago

This fixes it for me: https://github.com/elodina/go_kafka_client/pull/195