search

elonsoc / ods

An API provider that gives Elon University students access to university data.
https://ods.elon.edu/
1 stars 3 forks source link

Evancarr/frontend user flow #13

Closed ejrcarr closed 1 year ago

ejrcarr commented 1 year ago

What?

I created a simple frontend UI to recreate user flow shown previously on the Deisgn Document. Also reorganized file structure for better clarity.

Why?

These changes were made to demonstrate user flow and to act as placeholders until we are able to implement user auth.

How?

Implementation includes state management and css modules.

Testing?

I was prepared to test with Jest/Testing-Library but I need to clear it first to see our tentative plans with testing, which libraries?, etc.. I plan to add tests later for full coverage.

Screenshots

Screen Shot 2023-03-26 at 11 16 07 AM Screen Shot 2023-03-26 at 11 16 17 AM Screen Shot 2023-03-26 at 11 16 26 AM Screen Shot 2023-03-26 at 11 16 38 AM Screen Shot 2023-03-26 at 11 16 49 AM Screen Shot 2023-03-26 at 11 17 21 AM Screen Shot 2023-03-26 at 11 17 33 AM Screen Shot 2023-03-26 at 11 17 59 AM

Anything Else?

Just questions concerning user auth, typescript best practices, etc.

Purposefully did not disable add button if information is not added for testing purposes. Plan to incorporate further updates like such in additional versions.

ejrcarr commented 1 year ago

You can try removing that file--I made a new Layout component and I believe that one remains unused. It was just there when I began so I left it in case you had future plans with it or it was specific toward containerization. If there is no specific use then removing it should solve the error.

ejrcarr commented 1 year ago

Honestly was following Nextjs routing system through the docs and had no clue about the app directory. I will research and implement.

jumarmartin commented 1 year ago

No worries! Great first pass just some interesting implementation details to iron out. Great work!