eloquence / lib.reviews

A free/libre code and information platform for reviews of anything
Creative Commons Zero v1.0 Universal
171 stars 13 forks source link

returnto path #190

Closed pnoll1 closed 6 years ago

pnoll1 commented 6 years ago

adds returnto path for registration and sign in. Appears to work correctly on test server. The tests for:

pnoll1 commented 6 years ago

implemented using querys in latest commit, please review methodology. Also, added logic to handle traffic going directly to signin and registration pages.

eloquence commented 6 years ago

A lot nicer already! Still a couple outstanding issues, most importantly, we're still sometimes appending /signin or /register redirects. It also breaks a couple of tests, but we can fix that once those issues are addressed. See comments for details. :) Thanks again for working on this!

pnoll1 commented 6 years ago

implemented external redirect check using .includes('//'), let me know if regexp is more appropriate for some reason.

Still failing 3-register an account(captcha disabled) with expected 302, got 200 going directly to register page and creating new user appears to work as intended during my testing

pnoll1 commented 6 years ago

all tests passing

eloquence commented 6 years ago

Looks good! Merging, will make some minor cosmetic changes in a follow-up commit. Thank you again for your work on this. :)