elotl / kip

Virtual-kubelet provider running pods in cloud instances
Apache License 2.0
223 stars 14 forks source link

Set all needed EBS params in RunInstance request #222

Closed hidalgopl closed 3 years ago

hidalgopl commented 3 years ago

I noticed that if the AMI is created with gp3, iops and threshold set to values other than default, RunInstances request will fail. I bet this happens because we do not get those params from GetImage method. Also, it looks like aws ec2 sdk version that we're using does not have all the fields that can be specified for ec2 EBS Block Device (Threshold is missing). AWS API docs ref Probably we'll need to update aws sdk dependency to newer version to handle it properly