elotl / kip

Virtual-kubelet provider running pods in cloud instances
Apache License 2.0
223 stars 14 forks source link

Require setting resourceGroup in provider.yaml for Azure fixes #228 #230

Closed hidalgopl closed 3 years ago

hidalgopl commented 3 years ago

What's the problem this change is solving?

Before we required virtualNetwork name in format resourceGroup/vNetworkName, but it wasn't documented anywhere. I have gut feeling that we'll need resourceGroup anyway for other azure api requests, so I think it's better to require setting it separately by end user.