Add more debug logging when creating provider

elotl / kip

Virtual-kubelet provider running pods in cloud instances

Apache License 2.0

223 stars 14 forks source link

Add more debug logging when creating provider #89

Closed ldx closed 4 years ago

ldx commented 4 years ago

Two changes:

I added some V(5) logs when the provider is being created.
In Makefile, one can now use the DKR environment variable to choose img, docker or any other command line compatible client for building and pushing the kip image, e.g. make img DKR=docker will build the image via docker.

ldx commented 4 years ago

Should we be updating

https://github.com/elotl/kip/blob/c0c246b61a6885f20ab74e42aca2f85f2caaa5dc/deploy/manifests/virtual-kubelet/base/deployment.yaml#L71 to use v=5?

Other than that LGTM +1

I think that's fine for the default deployment. Users can easily override it via on overlay.