search

elotroalex / ed

A jekyll theme for minimal editions
Other
125 stars 132 forks source link

Sidebar popout realigns text as reading #29

Closed MartinPaulEve closed 7 years ago

MartinPaulEve commented 8 years ago

The sidebar popout method realigns current position within the text, which makes for a disorientating reading experience if one needs to access functionality within the sidebar. I would suggest that this should be changed to some kind of popover mechanism that doesn't realign the current page.

elotroalex commented 7 years ago

hm. weird it's not happening on my Firefox. let me try on Chrome, etc.

elotroalex commented 7 years ago

hm. can't seem to be able to reconstruct the realigning bug on any other browser

MartinPaulEve commented 7 years ago

Will try to replicate ASAP! Will take me a few days...

On Sat, 8 Jul 2017, 22:39 Alex Gil, notifications@github.com wrote:

hm. can't seem to be able to reconstruct the realigning bug on any other browser

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elotroalex/ed/issues/29#issuecomment-313882621, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_ot76G-TQYz4PS6xaNf7IZNtehj1jUks5sL_ccgaJpZM4IWmCc .

elotroalex commented 7 years ago

Was it a phone?

MartinPaulEve commented 7 years ago

It wasn't. I can still see the behaviour (the text moves to the right when you open the sidebar, rather than the sidebar moving "over" the whitespace at the left) but I am not sure it is as much of a problem as I made out and you can probably close this.

On 09/07/17 00:14, Alex Gil wrote:

Was it a phone?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elotroalex/ed/issues/29#issuecomment-313886443, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_ot25jCgX8qCdsroc_NebHoDN5BlCPks5sMA1ZgaJpZM4IWmCc.

-- Professor Martin Paul Eve Chair of Literature, Technology and Publishing Birkbeck, University of London

T: 0203 073 8420 E: martin.eve@bbk.ac.uk W: https://www.martineve.com R: 416, 43 Gordon Square, London, WC1H 0PD

Books: https://www.martineve.com/books/ Articles: https://www.martineve.com/c-v/

Series Editor: New Horizons in Contemporary Writing (Bloomsbury) Director, Birkbeck Centre for Technology and Publishing Founder, Open Library of the Humanities (https://www.openlibhums.org) Chief Editor, Orbit (https://www.pynchon.net) Senior Online Editor, Alluvium, (http://www.alluvium-journal.org)

elotroalex commented 7 years ago

ah! that is a feature, not a bug. I tried both. funny how some people like this way, some like yours. unable to decide between the two feedbacks, I have gone with the one with the cleanest code :p

Fixes #29

On Sun, Jul 9, 2017 at 3:47 AM, Martin Paul Eve notifications@github.com wrote:

It wasn't. I can still see the behaviour (the text moves to the right when you open the sidebar, rather than the sidebar moving "over" the whitespace at the left) but I am not sure it is as much of a problem as I made out and you can probably close this.

On 09/07/17 00:14, Alex Gil wrote:

Was it a phone?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elotroalex/ed/issues/29#issuecomment-313886443, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_ot25jCgX8qCdsroc_ NebHoDN5BlCPks5sMA1ZgaJpZM4IWmCc.

-- Professor Martin Paul Eve Chair of Literature, Technology and Publishing Birkbeck, University of London

T: 0203 073 8420 E: martin.eve@bbk.ac.uk W: https://www.martineve.com R: 416, 43 Gordon Square, London, WC1H 0PD

Books: https://www.martineve.com/books/ Articles: https://www.martineve.com/c-v/

Series Editor: New Horizons in Contemporary Writing (Bloomsbury) Director, Birkbeck Centre for Technology and Publishing Founder, Open Library of the Humanities (https://www.openlibhums.org) Chief Editor, Orbit (https://www.pynchon.net) Senior Online Editor, Alluvium, (http://www.alluvium-journal.org)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elotroalex/ed/issues/29#issuecomment-313904907, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOzrimpucV-YIHyLNruF3F--mdSbARLks5sMIV_gaJpZM4IWmCc .