search

elpaco-escience / scikit-talk

Scikit-talk is an open-source toolkit for processing collections of real-world conversational speech in Python. The toolkit aims to facilitate the exploration of large collections of transcriptions and annotations of conversational interaction.
Apache License 2.0
2 stars 0 forks source link

Refactor architecture to use pydantic #45

Open bvreede opened 10 months ago

bvreede commented 10 months ago

There are a number of limitations to the (data) classes we are using in the current architecture, and especially since we need to flexibly transition between json and our class structure, and want to be flexible to adapt to new analytical methods, I am strongly leaning to applying Pydantic instead of the current architecture.

@carschno can we take some time to explore/implement this together?

carschno commented 10 months ago

I agree that PyDantic would be a better solution for serialization and deserialization, especially when it comes to validation. Nevertheless, I think it makes sense to think about the specific limitations of the current implementation regarding data classes and how they specifically affect the required functionality (ie. what would this change fix now or in the future?).