search

elpaco-escience / talkr

https://elpaco-escience.github.io/talkr/
Apache License 2.0
0 stars 0 forks source link

Improve `plot_quality()` labeling #116

Closed mdingemanse closed 2 months ago

mdingemanse commented 3 months ago

Currently plot_quality() generates a three panel plot only one of which has a label, due to this line: 

    labels = c("", "", source),

But workflows.Rmd refers to these as A, B, and C. Better to use those as labels, so make it:

    labels = c("A", "B","C"),

And if we do need the source name, use a ggtitle() in panel C.

mdingemanse commented 3 months ago

Making this change (commit: https://github.com/elpaco-escience/talkr/compare/main...116-plot_quality) results in a better plot in the vignette:

image

PabRod commented 2 months ago

Fixed by updating snapshot (https://github.com/elpaco-escience/talkr/commit/93b6ae471682747ce87480da3743ef95838d03b7)