search

elpendor / ES-scraper

A scraper for EmulationStation
47 stars 41 forks source link

Wrong games matched #34

Closed Olifiers closed 10 years ago

Olifiers commented 10 years ago

Hi there!

Some wrong matches across all platforms are happening with the latest version. Roughly 50% of the games are being matched to art with a similar name, but not quite.

Examples are: Ogre Battles > Tactics Ogres Mega Man X > Mega Man 9 (actually, all 'Mega Man' map to 'Mega Man 9' Secret of Mana > Secret of Stars etc...

There will always be a common word between the rom and the match. So 'Street Fighter 2 Turbo' will be matched with art for 'Street Cop'.

It's making the script unusable at the moment. Any game starting with 'Super' (Super R-Type, Super Turrican etc.) are is mapper to 'Super Mario All Stars' and so on.

Although my examples are SNES, this is taking place across all platforms at the moment, from MAME to Intellivision.

Olifiers commented 10 years ago

Hum... Seems like the GetGame.php at thegamesdb.net is ignoring the platform parameter and passing lots of matches as results.

Perhaps Scraper could filter the matches belonging to the same platform, this would make most matches work.

elpendor commented 10 years ago

It's a TheGamesDB bug. Someone has already reported it and provided a commit to fix it so its kinda pointless to change the way the scraper works because of it.

elpendor commented 10 years ago

Did a quick fix for it anyway. Try it and let me know.

Olifiers commented 10 years ago

Nice, will try it out, sir! ;)

And congrats for the great job.

On Fri, Sep 20, 2013 at 4:13 PM, Juan Pablo notifications@github.comwrote:

Did a quick fix for it anyway.

— Reply to this email directly or view it on GitHubhttps://github.com/elpendor/ES-scraper/issues/34#issuecomment-24817501 .