Add push, unshift and splice methods

elpete / CFCollection

An array wrapper for functional programming

MIT License

6 stars 6 forks source link

Add push, unshift and splice methods #16

Closed tonyjunkes closed 6 years ago

tonyjunkes commented 6 years ago

Adds push(), unshift() and splice() methods.

Currently, splice() returns an array of removed items. Was debating if it should return the updated collection so open to feedback/suggestions.

tonyjunkes commented 6 years ago

Ouch. Ok not sure about all the failures but I'll take a peek if I missed something.

I guess ACF has some hiccups with how I implemented splice(). I'll start reviewing things so I can clean up this PR but I'll probably get delayed a bit with traveling to CF Summit.

elpete commented 6 years ago

Try rebasing off of development. I pushed some fixes for those Travis errors.