search

elplatt / seltzer

CRM for hackerspaces
GNU General Public License v3.0
104 stars 50 forks source link

Remove read-only username field & rename section #403

Closed chris18890 closed 6 years ago

chris18890 commented 6 years ago

Remove read-only username field & rename section

Before

image

After

image

chris18890 commented 6 years ago

@elplatt @ramgarden any objections to this?

ramgarden commented 6 years ago

Why was this removed?

chris18890 commented 6 years ago

It seemed superfluous as it's on the view tab and was a read only field I just thought the form looked (c)leaner without it

ramgarden commented 6 years ago

Does the username show on a different form anywhere else? It's good to know.

chris18890 commented 6 years ago

It's visible on the view tab of the user profile, and will be listed in joining emails etc; the app generally renders the user's name in a surname, firstname (middle name) format rather than the username, and the user can log in with their email address as well as username

ramgarden commented 6 years ago

ah OK then this is a great idea! Ship it!

chris18890 commented 6 years ago

Will merge on Friday to give others time to comment