add createdBy attribute - closes #357 #331 - v0.6.0

[chris18890]

add createdBy attribute - closes #357; closes #331 - v0.6.0

[chris18890]

@elplatt / @ramgarden another one for yous to review!

[chris18890]

This is the email view

This is the DB view from PHPMyAdmin

Realised that the string for the table isn't rendering correctly as I'm using theme(contact_name($cid)) so need to put a bit of logic int here to test if it's an int or a string

[ramgarden]

How does a person self register?

On Wed, May 27, 2020 at 12:33 PM Chris Murray notifications@github.com wrote:

This is the email view

[image: image] https://user-images.githubusercontent.com/3144892/83047288-10e4c280-a040-11ea-9dc9-d9245923fbe8.png

[image: image] https://user-images.githubusercontent.com/3144892/83047306-193cfd80-a040-11ea-888b-5286cc5fe343.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elplatt/seltzer/pull/450#issuecomment-634785718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU4DTIAMS3RN3CA23SSLYTRTU6HLANCNFSM4NI4P6ZA .

[chris18890]

If the “register” module is enabled, there’s a “register” link at the top right side beside login & reset password :)

[ramgarden]

OH! I guess we've never used the register module since all new members go through our secretary/admin handful of users.

On Wed, May 27, 2020 at 2:10 PM Chris Murray notifications@github.com wrote:

If the “register” module is enabled, there’s a “register” link at the top right side beside login & reset password :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elplatt/seltzer/pull/450#issuecomment-634846342, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU4DTJU5NNZGWRW3RT76F3RTVJRDANCNFSM4NI4P6ZA .

[chris18890]

@ramgarden you should upgrade to the latest release of master & give it a go :P

[chris18890]

@ramgarden @elplatt do you think it's worth adding createdDate & createdTime attributes to contacts as well, & adding these attributes to plans/keys etc?

[ramgarden]

I'd say keys and plans don't need the create date since they have start date. But I can see rare cases where a new member might set their membership to start in the future. So in that case the create date would be different than start date. At Melbourne Makerspace we always add new members right on their start day. But there might get be cases where we would want to add the contact but they won't really start a paid membership until next week or next month. Perhaps adding these fields would be good to have? Do we need to worry about the extra data storage it adds for those hosting on servers with DB quotas for free tiers?

On Thu, May 28, 2020, 9:32 AM Chris Murray notifications@github.com wrote:

@ramgarden https://github.com/ramgarden @elplatt https://github.com/elplatt do you think it's worth adding createdDate & createdTime attributes to contacts as well, & adding these attributes to plans/keys etc?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elplatt/seltzer/pull/450#issuecomment-635352251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU4DTODROSFNV63G3L64HTRTZRWFANCNFSM4NI4P6ZA .

[chris18890]

@ramgarden I was thinking more about adding the createdDate to the plan object itself, the start date refers to the membership which is the link between plans & members IIRC.

As for the data storage, I hadn't really considered that TBH, I wouldn't've thought it'd take up that much more space...