Permission changes - Githubissues

chris18890 commented 2 years ago

There are 2 significant changes here:

To display the "user role edit" tab & form, on the member page, the logged in user must now have the "user_role_edit" permission instead of "member_membership_edit", which makes more sense as it now matches the required permission for the command.
I've also split out the edit & delete ops for subscriptions, the delete op now requires the member_edit permission; this means that if spaces wish to allow the users to self-manage their subscription, this can now be done by allowing members to have the "member_membership_edit" permission to add & edit subscriptions, but prevents them from removing a subscripton completely

chris18890 commented 2 years ago

can I get a review on this @ramgarden @elplatt?

chris18890 commented 2 years ago

I've removed some of the SQL changes as they weren't working as expected, nor was the mentor edit form, so they'll be 0.7.6 :P

chris18890 commented 2 years ago

have fixed & re-tested the SQL code so can this be re-reviewed? @elplatt @ramgarden ?

elplatt / seltzer